GRI-2141: fail-first tests for panel language switching (Dutch), forge #275 #289
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!289
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-2141-panel-language-switching-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Forge #275 ("Tests: panel language switching (Dutch)"): fail-first tests for the panel's language switcher, written against the specification ahead of #38's implementation, per Grimoirix process (Test Writer writes before the implementing engineer).
What's covered
frontend-web/src/api/httpSessionApi.test.ts— pins the already-merged server contract (forge #274 / PR #276):localeon everyGET/POST /sessionresponse, a newupdateLocale(locale)→PATCH /session/locale, and400 unknown_localesurfacing asApiRequestError.frontend-web/src/panelLanguageSwitching.test.tsx— one test per acceptance criterion in forge #275:panel.nav.settings(deliberately missing fromnl.yml), not a raw key or blankdocument.documentElement.langmatches the active localeWhere the control lives and what widget it is are the implementing engineer's call (the issue only says "somewhere in settings"); the tests assume an accessible name matching
/language/i(required anyway by the accessibility criterion) and handle either a native<select>or a button-opened listbox.Test plan
npx vitest runinfrontend-web: all 11 new/updated assertions fail against today's code (missingupdateLocaleexport, missinglocalefield, no control rendered); the other 181 existing tests are unaffected.npx tsc -b --noEmit: fails only on the missingupdateLocaleexport — the exact symbol the implementation needs to add.npx prettier --check/npx oxlint --deny-warningson both files: clean.Superseded by #294, merged into dev: its commit
6fe624fis already an ancestor of dev. Closing.Pull request closed