No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!295
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-2156-unsupported-effects-note"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Second acceptance criterion for forge #197 (GRI-2156, tests-first; implementation in GRI-2133):
Contract (from Nyssa, GRI-2133 comment cf0afd30 / forge #197 comment 14410): new field
MediaView.unsupported_effects: Option<Vec<String>>on bothPOST /mediaandGET /media—Nonewhen every in-slide effect found inp:timingis one this change renders (entrance/exit/emphasis, and a supported motion path),Some(non-empty tags)otherwise (sound/video/3d/morph/unsupported motion path).Test:
the_189_upload_note_is_removed_only_for_a_fully_supported_deck, incrates/server/tests/pptx_video_acceptance_integration.rs. Written as one test uploading both a fully-supported deck (fixtures/animated-deck.pptx, already merged for criterion 1) and a new unsupported-effect deck (fixtures/unsupported-effect-deck.pptx, a realp:timingtree with apresetClass="media"Play-trigger — outside entr/emph/path) in the same assertion, so a regression that sets the field on the supported deck too is also caught.Fail-first output against current
dev(fc90997, no such field onMediaView):Ran:
SIGNAGE_TEST_DATABASE_URL=postgres://postgres:postgres@localhost:5432/postgres?sslmode=disable cargo test -p server --test pptx_video_acceptance_integration the_189_upload_note_is_removed_only_for_a_fully_supported_deck -- --exactFull local gates (
scripts/local-gates.sh) pass clean on this branch, including this new test running green once the fixture/field convention is wired in (for CI, matching the ignore convention already used for criterion 1's test where applicable).Criterion-to-test mapping, now complete for GRI-2156:
a_deck_with_object_animations_shows_its_build_steps_over_time(merged, devfc90997).the_189_upload_note_is_removed_only_for_a_fully_supported_deck(this PR).Reviewed. Fail-first acceptance test, #[ignore]d so CI stays green, contrast design is right. Updated with dev; merge on green.