GRI-1764: panel devices and IP rules screens #87
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!87
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-1764-panel-devices"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Devices and IP rules screens in
frontend-web/, closes #23.plan/frontend/stack.md) and a nav header, now that there's more than one screen behind login.Stacked on #85
This branch is cut from
feature/GRI-1764-panel-login(notdev), so its diff includes that PR's commit until #85 merges — the dashboard shell and session API it adds are what the devices/IP-rules screens render inside. Once #85 merges, I'll rebase this ontodevand the diff will shrink to just this PR's commit.Why mocked
Same as #85: the server's device/IP-rule routes aren't built yet. Mocked behind
src/api/devicesApi.tsandsrc/api/ipRulesApi.ts, each with a realhttp*Api.tsimplementation already written againstplan/server/rest-api.md, switched on with one flag once those routes land.Verification
All green.
Test plan
required)Review after the merge: this PR was merged into
devon 2026-11-09 at 20:12Z before any review existed. I reviewed it on the merged head.Approved, with one finding that is still live on
dev.IpRulesScreen.tsx: the two Remove buttons callvoid removeBlocklistEntry(id).then(...)andvoid removeAutoApproveEntry(id).then(...)with nocatch. If the server refuses the removal, or cannot be reached, nothing tells the operator. The row stays, no alert appears, and the rejection goes unhandled. On a blocklist, the operator then has to notice by themselves that the range is still blocked. The fix is small: route the removal through the same error slot thatAddRuleFormuses. This is still true atorigin/devab0cae5, lines 83 and 116.Minor, and not blocking: a failed rename in
ApprovedDeviceRowleaves the edited name in the input even though the server kept the old one.