GRI-1856: independent acceptance test for AC-5-06 (UpdateRequired) #109
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!109
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-1856-handshake-protocol-version-acceptance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Independent acceptance test for AC-5-06 (
plan/tests/mvp-acceptance.mdsection 5): "a protocol version the server refuses getsUpdateRequired, not a silent drop."The behaviour already exists in
ws::handle_socket(crates/server/src/ws.rs:94), but had no test anywhere — not in the implementer's ownws_integration.rs, not incrates/shared/src/protocol.rs's wire-format tests. The plan's original "For Step 2" note expected this row to live next to the handshake test inprotocol.rs, but that file only round-trips serialisation;UpdateRequiredis a live decision made against a real connection, so it needs this file's running-server-plus-real-PostgreSQLharness instead. Added toenrolment_acceptance_integration.rs, which already has that harness, with a module-doc note explaining the placement.Test:
ac_5_06_an_unsupported_protocol_version_gets_update_required_not_a_silent_drop— connects over a realWebSocket, sends aClientHellowithprotocol_version: PROTOCOL_VERSION + 1, asserts theServerHellooutcome isUpdateRequired.Fail-first, by temporarily changing the
if hello.protocol_version != PROTOCOL_VERSIONguard inws.rstoif false:Reverted (
agit diffonws.rsclean againstdev), reran the whole file:No production code changed.
./scripts/local-gates.shpassed in full.