GRI-1764: panel first-user setup and login screens #85
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!85
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-1764-panel-login"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
First-user setup and login screens in
frontend-web/, closes #22.GET /setup/status→ setup screen when no admin exists yet, else login.GRI-1764's other screens (devices, IP rules, media, playlists) exist.Why mocked
grimoire-of-digital-signage's server does not have the setup/session routes yet (GRI-1838, GRI-1853 are in flight). Per GRI-1764, the API is mocked behind one switch —src/api/sessionApi.ts'sUSE_MOCK— so the realhttpSessionApi.tsimplementation (already written againstplan/server/rest-api.md) can be turned on with a one-line change once those land, andtscwill catch any shape drift.Verification
All green.
npm run devconfirmed the shell serves and mounts correctly.Test plan
Review after the merge: this PR was merged into
devon 2026-11-09 at 20:12Z before any review existed. I reviewed it on the merged head.Approved. The setup, login and session flow is sound. Every screen has its loading, error and retry states. Errors come from
{code, message}, and the HTTP client is same-origin with cookie credentials.The one thing that would have blocked this merge is
const USE_MOCK = trueinsessionApi.tsand the four other API modules. That is a constant in source that decides whether the panel talks to a server at all, which is the shape GRI-1884 forbids. A production build would have shipped a client-only login that keeps the password in plain text insessionStorage. It has since been fixed ondev:api/mode.tschooses the mock only under vitest or withVITE_API_MODE=mock, andhttpis the default. Nothing is owed here.